Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Move notification to be child of preview content #1019

Merged
merged 4 commits into from
Jun 19, 2019

Conversation

ConradJChan
Copy link
Contributor

@ConradJChan ConradJChan commented Jun 18, 2019

In PreviewUI.js, introduced previewContainer which points to .bp div. Existing contentContainer (which used to point to .bp) is now .bp-content which is only used for Notification.js

Also changed the default "Okay" to use the close.svg

Centered banner

@boxcla
Copy link

boxcla commented Jun 18, 2019

Verified that @ConradJChan has signed the CLA. Thanks for the pull request!

src/lib/Notification.js Outdated Show resolved Hide resolved
src/lib/PreviewUI.js Show resolved Hide resolved
@@ -390,7 +390,7 @@ class DocPreloader extends EventEmitter {
*/
checkDocumentLoaded() {
// If document is already loaded, hide the preload and short circuit
if (this.previewUI.contentContainer.classList.contains(CLASS_PREVIEW_LOADED)) {
if (this.previewUI.previewContainer.classList.contains(CLASS_PREVIEW_LOADED)) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll probably want to triple-check that preload is dismissing on load. 😄

@ConradJChan ConradJChan merged commit fde40a0 into box:master Jun 19, 2019
@ConradJChan ConradJChan deleted the move-notification-bar branch June 19, 2019 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants